Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Yajl as the json parser, in order to accept malformed json messages #46

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcosfparreiras
Copy link

This PR is proposed to fix the issue #45.

The issue contains the full context of:

  • what is the issue
  • how it was identified
  • why we need to fix it
  • why using Yajl is the proposed fix

@dynatrace-cla-bot
Copy link
Member

dynatrace-cla-bot commented Dec 14, 2023

CLA assistant check
All committers have signed the CLA.

@marcosfparreiras marcosfparreiras force-pushed the use-yajl-to-serialize-records branch from 9323420 to 62ce767 Compare December 14, 2023 11:52
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to review. It looks good to me and I appreciate that you added the test.

@dyladan

This comment was marked as off-topic.

@dyladan dyladan closed this Apr 30, 2024
@dyladan dyladan reopened this Apr 30, 2024
@dyladan
Copy link
Member

dyladan commented Apr 30, 2024

Closed and reopened to trigger PR checks

@dyladan
Copy link
Member

dyladan commented Apr 30, 2024

2.7 failing tests not related to this PR

they are fixed by #51

@dyladan
Copy link
Member

dyladan commented Apr 30, 2024

Can you bump the patch version in lib/fluent/plugin/dynatrace_constants.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants